Should undefined declaration be removed?

GroteGnoom · 14 January 2021 09:11

igraph_nonlinear_barabasi_game is declared here:

igraph/igraph/blob/db89a7e5ed8e5ae29287bd96c76c765873427ec9/include/igraph_games.h#L50


DECLDIR int igraph_barabasi_game(igraph_t *graph, igraph_integer_t n,
                                 igraph_real_t power,
                                 igraph_integer_t m,
                                 const igraph_vector_t *outseq,
                                 igraph_bool_t outpref,
                                 igraph_real_t A,
                                 igraph_bool_t directed,
                                 igraph_barabasi_algorithm_t algo,
                                 const igraph_t *start_from);
DECLDIR int igraph_nonlinear_barabasi_game(igraph_t *graph, igraph_integer_t n,
        igraph_real_t power,
        igraph_integer_t m,
        const igraph_vector_t *outseq,
        igraph_bool_t outpref,
        igraph_real_t zeroappeal,
        igraph_bool_t directed);
DECLDIR int igraph_erdos_renyi_game(igraph_t *graph, igraph_erdos_renyi_t type,
                                    igraph_integer_t n, igraph_real_t p,
                                    igraph_bool_t directed, igraph_bool_t loops);
DECLDIR int igraph_erdos_renyi_game_gnp(igraph_t *graph, igraph_integer_t n, igraph_real_t p,

But it is never defined, the only reference to it is here:

github.com

igraph/igraph/blob/db89a7e5ed8e5ae29287bd96c76c765873427ec9/src/games/games_other.c#L470


*          bag, with replacement. This method might generate multiple
*          edges. It only works if power=1 and A=1.
*        \cli IGRAPH_BARABASI_PSUMTREE
*          This algorithm uses a partial prefix-sum tree to generate
*          the graph. It does not generate multiple edges and
*          works for any power and A values.
*        \cli IGRAPH_BARABASI_PSUMTREE_MULTIPLE
*          This algorithm also uses a partial prefix-sum tree to
*          generate the graph. The difference is, that now multiple
*          edges are allowed. This method was implemented under the
*          name \c igraph_nonlinear_barabasi_game before version 0.6.
*        \endclist
* \param start_from Either a null pointer, or a graph. In the former
*        case, the starting configuration is a clique of size \p m.
*        In the latter case, the graph is a starting configuration.
*        The graph must be non-empty, i.e. it must have at least one
*        vertex. If a graph is supplied here and the \p outseq
*        argument is also given, then \p outseq should only contain
*        information on the vertices that are not in the \p
*        start_from graph.
* \return Error code:

This method was implemented under the name \c igraph_nonlinear_barabasi_game before version 0.6.

Should the declaration be removed?

vtraag · 14 January 2021 13:15

The implementation is removed in Barabasi game generator rewritten, fixes bug #409346. · igraph/igraph@d224119 · GitHub, when the new implementation was written. Usually, these functions should have been deprecated, but apparently that was not done for this function. For 0.9 we are removing functions that have been deprecated before 0.8 (I believe that was the policy we agreed on @tamas and @szhorvat ?), so the declaration of igraph_nonlinear_barabasi_game can also be safely removed from the develop branch.

tamas · 14 January 2021 21:11

Yes, that’s the policy, and igraph_nonlinear_barabasi_game can safely be removed.