TODO in unweighted shortest path implementations (BFS)?

szhorvat · 3 March 2020 09:25

@Gabor Do you recall why this is marked as TODO? I don’t see what’s wrong. There are several instances of the same and I am working with this code at the moment.

github.com

igraph/igraph/blob/master/src/structural_properties.c#L252


*res = 0;
if (directed) {
    dirmode = IGRAPH_OUT;
} else {
    dirmode = IGRAPH_ALL;
}
already_added = igraph_Calloc(no_of_nodes, long int);
if (already_added == 0) {
    IGRAPH_ERROR("average path length failed", IGRAPH_ENOMEM);
}
IGRAPH_FINALLY(free, already_added); /* TODO: hack */
IGRAPH_DQUEUE_INIT_FINALLY(&q, 100);


igraph_adjlist_init(graph, &allneis, dirmode);
IGRAPH_FINALLY(igraph_adjlist_destroy, &allneis);


for (i = 0; i < no_of_nodes; i++) {
    nodes_reached = 0;
    IGRAPH_CHECK(igraph_dqueue_push(&q, i));
    IGRAPH_CHECK(igraph_dqueue_push(&q, 0));
    already_added[i] = i + 1;

Gabor · 3 March 2020 09:42

Because it assumes that igraph_Free() is the same as free().

igraph_Free() is a macro, so you cannot take its address, but we should also define igraph_Free() as a function, in addition to the macro, and then we could use it here as well.

szhorvat · 3 March 2020 10:00

We already have the function igraph_free(). I’ll change it to that.

Topic		Replies	Views
Should undefined declaration be removed? Development C	2	311	14 January 2021
#pragma omp parallel: igraph_error.c:186: IGRAPH_FINALLY_REAL: Assertion `no < 100' failed Usage C	5	593	18 February 2021
Need help with igraph error:[ igraph_error.c:186: Assertion `no < 100’ failed.’] Usage C	5	525	15 October 2020
rational behind the typedef igraph_vector Development C	8	382	8 November 2021
Help! Error Again Assertion `no < 100’ failed in igraph 0.8.3 Usage C	11	734	21 October 2020

TODO in unweighted shortest path implementations (BFS)?

Related Topics